Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Rename and update documentation for Add/RemoveDirectorySeparator methods. #25

Closed
alphaleonis opened this issue Jan 15, 2015 · 0 comments
Closed

[CLOSED] Rename and update documentation for Add/RemoveDirectorySeparator methods. #25

alphaleonis opened this issue Jan 15, 2015 · 0 comments
Milestone
Version 2.0

Comments

@alphaleonis
Copy link
Owner

Issue by alphaleonis from Wednesday Jan 07, 2015 at 12:48 GMT
Originally opened as #25

AddDirectorySeparator should be renamed to AddTrailingDirectorySeparator to clarify its purpose. Its documentation should be updated to reflect that this is what it is doing. Also documentation needs to be updated to reflect what the difference between this method and GetSuffixedDirectoryName is.

RemoveDirectorySeparator should consequently be renamed to RemoveTrailingDirectorySeparator. Same updates to documentation.
@alphaleonis alphaleonis added this to the Version 1.6 milestone Jan 15, 2015
alphaleonis pushed a commit that referenced this issue Jan 15, 2015
@Yomodo
WIP FIX #25
9f32ab4
alphaleonis pushed a commit that referenced this issue Jan 15, 2015
@Yomodo
Fixes #25
db948db
alphaleonis pushed a commit that referenced this issue Jan 15, 2015
@Yomodo
Merge pull request #30 from alphaleonis/UpdateRemoveDirectorySeparator
13e66bf 
Update remove directory separator
Fixes #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 2.0
Development

No branches or pull requests
1 participant
@alphaleonis