Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room list visibility cache includes event data #256

Closed
alphapapa opened this issue Jan 23, 2024 · 2 comments · Fixed by #257
Closed

Room list visibility cache includes event data #256

alphapapa opened this issue Jan 23, 2024 · 2 comments · Fixed by #257
Assignees
Labels
bug Something isn't working
Milestone

Comments

@alphapapa
Copy link
Owner

I just realized that the persisted value of ement-room-list-visibility-cache includes room event data. On my account, that serialized to over 150 MB (which could explain some apparent slowness for some users at times).

Fixing this requires that we define a subclass of magit-section to insert our sections as, and then an ident value function to return simple identifiers (e.g. room ID-session ID pairs).

Then we must pass that subclass to taxy-magit-section-insert. That will require a new version of taxy-magit-section, but it's a simple change.

@alphapapa alphapapa self-assigned this Jan 23, 2024
@alphapapa alphapapa added the bug Something isn't working label Jan 23, 2024
@alphapapa alphapapa added this to the 0.14 milestone Jan 23, 2024
alphapapa added a commit that referenced this issue Jan 23, 2024
@alphapapa
Copy link
Owner Author

See alphapapa/taxy.el@f43bbf6

@alphapapa alphapapa linked a pull request Jan 23, 2024 that will close this issue
@alphapapa
Copy link
Owner Author

I've pushed taxy-magit-section v0.13. It should appear on ELPA in the next day. Then this can be merged.

alphapapa added a commit that referenced this issue Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant