Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tip on how to start the mode automatically. #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kaligule
Copy link

No description provided.

@alphapapa alphapapa self-assigned this Aug 15, 2022
@alphapapa alphapapa added the docs Issues relating to documentation label Aug 15, 2022
@alphapapa alphapapa added this to the 1.6 milestone Aug 15, 2022
@alphapapa
Copy link
Owner

Seems like a good idea, thanks.

@Kaligule
Copy link
Author

It seems like you forgot to merge it. Or did I miss something?

@alphapapa
Copy link
Owner

alphapapa commented Sep 17, 2022

IIRC, it seemed like further reflection was needed. I'm not sure that activating with magit-mode-hook makes sense, because that mode is activated every time a magit- buffer is initialized, and the initialization done with magit-todos-mode only needs to be done once. I think that simply doing (magit-todos-mode) is all that's necessary.

Also, why is that line in the readme changed?

Thanks.

@Kaligule
Copy link
Author

Having (magit-todos-mode) in my config didn't work for me I think. It seemed to me that magit has already to be running when magit-todos-mode is started. Thats why I used the hook.

Also, why is that line in the readme changed?

Which line do you mean?

@alphapapa
Copy link
Owner

Having (magit-todos-mode) in my config didn't work for me I think. It seemed to me that magit has already to be running when magit-todos-mode is started. Thats why I used the hook.

To get to the bottom of this, we'll have to be more specific. Please try to reproduce the problem in a clean Emacs config, e.g. using https://github.com/alphapapa/with-emacs.sh (Aside: This is why I generally recommend filing an issue describing a problem before sending a PR that seems to fix something. We should identify a problem before proposing a change. And if we make a change that seems to fix something in your personal config, it may break other users' configs.)

Also, why is that line in the readme changed?

Which line do you mean?

The one that changes the description of the link to the TRAMP usage notes.

@alphapapa alphapapa modified the milestones: 1.6, 1.7 Mar 7, 2023
@alphapapa alphapapa modified the milestones: 1.7, 1.8 Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues relating to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants