-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spellcheck of docstrings #7
Comments
I'd be glad to support that. I don't mind enabling it by default, although I guess I'll have to gate that code on the Emacs version, right? |
I see, only the batch part is new. I think that should do it. I don't have Emacs 27 installed, so please let me know if it works properly. :) |
Thank you |
@DamienCassou Hmm, I'm not sure if this is a good idea to enable by default yet. For example: https://github.com/alphapapa/plz.el/runs/420621309?check_suite_focus=true#step:5:10 Do you have any ideas? |
As with all linters, you will get good feedback and some less good one. I suggest adding the words you like to the file's local dictionary. This can be done with ; LocalWords: undecoded struct unparsed You can also change the words:
|
aspell uses the language from |
@tastytea Is aspell always the backend that's used? Do users in other locales already have to change that when running |
The manual mentions “Hunspell, Aspell, Ispell or Enchant“ as possible backends. hunspell also uses Users in other locales have to set While programmers are likely to have the right dictionary already set up, local calls to CI images often have no locale installed and set |
no. The user can choose through
I've never had any issue. I always write code in English but I regularly change the dictionary for written text. Maybe makel could set english as default because this is what most elisp is written in and let users change that. |
The checkdoc lint failed on my Github Action, no spell program seems to be installed with the default
For now, I set For what it's worth, the checkdoc also fails locally on my machine, even though it seems to discover aspell:
|
Yes, and it used to work, and it stopped working without any changes in this repo, so unfortunately something changed in one of the dependencies, and I haven't bothered to go looking for what got broken yet. Probably one of the Nix Emacs things stopped installing aspell by default, or something like that. |
I've run into an issue with I'm working around it like so in (advice-add 'checkdoc-file :before (lambda (_) (ispell-kill-ispell t t))) |
Can this be opt-in (with dir-locals), or if not, can there be a simple way to opt out? |
See also #39. |
FYI to those who are interested: 4bdfd81 should make this much easier for custom words. Thanks to @josephmturner. |
Thanks to this patch, Emacs 27 can now spellcheck docstrings when run in batch mode. This requires setting
checkdoc-spellcheck-documentation-flag
to a non-nil value as nil is the default.Would you consider changing the value of this variable or letting the user change it?
The text was updated successfully, but these errors were encountered: