Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When multiple sorters are specified, something mutates the sorter list after first successful run #136

Closed
natrys opened this issue Aug 22, 2020 · 2 comments
Assignees
Labels

Comments

@natrys
Copy link
Contributor

natrys commented Aug 22, 2020

Setup

Emacs: GNU Emacs 28.0.50
Org-mode: 9.3
org-ql: org-ql-20200713.309
org-super-agenda version: org-super-agenda-20200310.1337

Issue

Hello, I am really grateful for this package (and org-super-agenda) and it helped me a lot in the last ~2 years (as I can't really make sense of built-in agenda).

The issue I am facing is that when multiple sorters are specified (such as with :sort '(deadline priority date)), it works perfectly in the first run, but then org-ql-view-sort gets weirdly mutated (to just the first sorter it seems (e.g. '(deadline)).

This means subsequent refresh with r, g doesn't produce the same view again.

Reproduction

(setq my-sorting-functions '(deadline priority date))

(org-ql-search "~/empty.org"
  '(todo)
  :super-groups nil
  :sort my-sorting-functions)

(print my-sorting-functions) ;; ==> Now it is changed to '(deadline) so is `org-ql-view-sort` in the buffer
@alphapapa
Copy link
Owner

Thanks, I hadn't noticed this issue. Your PR is probably the right fix. I will look at it when I have time.

@alphapapa alphapapa self-assigned this Aug 23, 2020
@alphapapa alphapapa added the bug label Aug 23, 2020
@alphapapa
Copy link
Owner

Fixed in 29090c4 and 0.4.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants