Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #239 #298

Closed
wants to merge 9 commits into from
Closed

update #239 #298

wants to merge 9 commits into from

Conversation

bhuztez
Copy link

@bhuztez bhuztez commented Aug 26, 2022

update #239 with two changes

use existing ID if org-id-link-to-org-use-id is not nil

rename :scope to :buffers-files

@alphapapa
Copy link
Owner

@bhuztez If you would like to propose changes to those proposed in another PR, please do it on that PR rather than creating yet another one. It's hard enough to keep track of these as it is.

@bhuztez
Copy link
Author

bhuztez commented Aug 27, 2022

@alphapapa sorry, I did not find a way to add my patch to that pull request. so that I made a new one.

@alphapapa
Copy link
Owner

@bhuztez You can post your suggested code in a comment on that PR, or link to a branch on your repo, etc. Having a PR on top of another PR that is not yet merged makes the proposals hard to keep track of, especially if the other PR ends up having further changes before being merged.

@alphapapa alphapapa closed this Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants