Removed check for 'dotime in time-grid. #221
Conversation
|
Well, as you can see from the removed comment, that code was added by necessity after much research and testing of the org-agenda code's output. While removing it might fix the TODO search in your case, it would probably also break other agenda/search types, which is the main use case for this package. I couldn't merge this unless it could be confirmed that 1) Org has changed something and doesn't use this text property anymore, and 2) the Org version in which such a change happened is the minimum supported by this package (which wouldn't be likely to happen for some time). |
|
Unfortunately, I don't know what testing you've done to be able to tell when you needed the dotime check. Maybe another On another note, I really appreciate the work you've put into this package, and it fits heavily into my daily workflow. I apologize for not being able to offer a more nuanced solution to this problem you obviously spent a while considering already. Maybe some day I'll be able to take the time to examine org-agenda's usage of the dotime property to figure out a better solution for this issue. |
|
Fixing this will require some research and testing to confirm that nothing else gets broken. In the meantime, I can recommend using @tuh8888 Thanks for the kind words. |
Possible fix for #212
Might be a naive solution, but I'm not sure what the check for
'dotimeis supposed to account for. This solved the issue for my configuration and use-case. I'm not sure how your testing framework works in order to see if I've messed anything else up that you've already thought of though.