Quick fix of #75 #80
Open
Quick fix of #75 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes the redundant `outshine-defkey` and `outshine-remap` functions since the command-remapping functionality has been available from Emacs 22. - Move remapping of self-insert-command to the Key bindings section
The original appears to be taken org-self-insert-command and left unchanged by mistake.
The only purpose of remapping self-insert-command for speed commands, so do not remap at all if `outshine-use-speed-commands' is nil. The remapping breaks compatibilty with multiple-cursors and potentially other modes which depend on self-insert-command.
|
Thanks. However, the consequence you mention is an important one. The idiomatic way to fix this would be to define an |
|
I'm aware of this, which is why it's labeled a "quick fix". Feel free to only merge the first 2 commits or implement the additional minor mode afterwards, or just leave this here for others to reference in their own forks. The current code as I recall is incompatible with multiple-cursors and other packages which rely on self-insert-command. Note that other packages like Evil and outline-minor mode itself also have similar caveats with vars that must be set before package load. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops an obsolete workaround for remapping keys and fixes #75 by wrapping the offending code in a
(when outshine-use-speed-commands )block.The consequence of this is that
outshine-use-speed-commands(nilby default) has to be enabled before the package is loaded, and changing it afterwards does not have any effect.