Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete preexisting files with :as 'file (data-loss) #41

Merged
merged 3 commits into from
Jan 14, 2024

Conversation

josephmturner
Copy link
Contributor

I think deleting the temp file makes sense, but existing files should be left alone.

@alphapapa alphapapa self-assigned this Oct 7, 2023
@alphapapa alphapapa added the bug Something isn't working label Oct 7, 2023
@alphapapa alphapapa added this to the 0.7.1 milestone Oct 7, 2023
@alphapapa
Copy link
Owner

Thanks. I want to release this fix in a v0.7.1, but since v0.8-pre is already pushed, I'm not sure if we can do that for GNU ELPA without updating the package definition to pull from a stable branch. I've emailed Stefan Monnier asking about the best way to handle it.

@josephmturner
Copy link
Contributor Author

I see that 0.7.1 was pushed. What did you learn with Stefan?

@alphapapa alphapapa modified the milestones: 0.7.1, 0.7.2 Jan 14, 2024
@alphapapa
Copy link
Owner

Apparently I learned that I am forgetful, as I forgot to fix this bug after talking with him. :) ELPA now pulls from the stable branch, which allows stable bug-fix releases to be made independently of master. I'll fix this soon...

@josephmturner
Copy link
Contributor Author

All good :) I figured that a separate stable branch would be the solution.

Copy link
Owner

@alphapapa alphapapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding me about this.

plz.el Outdated Show resolved Hide resolved
plz.el Show resolved Hide resolved
plz.el Show resolved Hide resolved
@alphapapa alphapapa merged commit 0b2fc91 into alphapapa:master Jan 14, 2024
@alphapapa
Copy link
Owner

Thank you!

@josephmturner josephmturner deleted the as-file-fixes branch March 9, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants