Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are parts of some URLs colored? #36

Closed
oantolin opened this issue Jan 29, 2022 · 4 comments · Fixed by #40
Closed

Why are parts of some URLs colored? #36

oantolin opened this issue Jan 29, 2022 · 4 comments · Fixed by #40

Comments

@oantolin
Copy link

image

This doesn't actually bother me, but I do find it unusual that for some URLs in the "Site" column the initial portion is colored the same color as the title. Look at proteanmag which is colored up to the m, or getpocket.com which is colored upto the c in com. Weird, right?
@alphapapa
Copy link
Owner

I don't know, I've never seen that behavior. You could try using C-u C-x = to examine the faces of those characters.

bcc32 added a commit to bcc32/pocket-reader.el that referenced this issue Mar 1, 2022
@bcc32
Fontify based on rendered column widths
661c8b8 
When tabulated-list-mode renders a line, it considers the remaining
available space in the selected window and may reduce the width of a
column compared to the width specified in tabulated-list-format.  As a
result, fontifying or otherwise calculating offsets based on the
widths in tabulated-list-format can lead to colors bleeding over into
the next column.

Delete function pocket-reader--column-data, which returns the
"theoretical" start and end positions of each column, and instead use
the actual text properties in the buffer.

Fixes alphapapa#36.
bcc32 added a commit to bcc32/pocket-reader.el that referenced this issue Mar 1, 2022
@bcc32
Fontify based on rendered column widths
b2b7c0e 
When tabulated-list-mode renders a line, it considers the remaining
available space in the selected window and may reduce the width of a
column compared to the width specified in tabulated-list-format.  As a
result, fontifying or otherwise calculating offsets based on the
widths in tabulated-list-format can lead to colors bleeding over into
the next column.

Delete function pocket-reader--column-data, which returns the
"theoretical" start and end positions of each column, and instead use
the actual text properties in the buffer.

Fixes alphapapa#36.
@bcc32 bcc32 mentioned this issue Mar 1, 2022
Merged
@alphapapa
Copy link
Owner

@oantolin Given the information in #40, I'm guessing this bug is caused by changes in tabulated-list-mode in newer Emacs versions. What version are you using?

@oantolin
Copy link
Author

oantolin commented Mar 5, 2022

I'm using a build of Emacs 28.0.50 from april 2021, so moderately new.

bcc32 added a commit to bcc32/pocket-reader.el that referenced this issue Nov 3, 2022
@bcc32
Fontify based on rendered column widths
a3c802d 
When tabulated-list-mode renders a line, it considers the remaining
available space in the selected window and may reduce the width of a
column compared to the width specified in tabulated-list-format.  As a
result, fontifying or otherwise calculating offsets based on the
widths in tabulated-list-format can lead to colors bleeding over into
the next column.

Delete function pocket-reader--column-data, which returns the
"theoretical" start and end positions of each column, and instead use
the actual text properties in the buffer.

Fixes alphapapa#36.
@alphapapa
Copy link
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fontify based on rendered column widths bcc32/pocket-reader.el
2 participants
@alphapapa @oantolin