Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags containing spaces not working #43

Closed
pataquets opened this issue Oct 27, 2022 · 5 comments
Closed

Tags containing spaces not working #43

pataquets opened this issue Oct 27, 2022 · 5 comments
Assignees
Labels
Milestone

Comments

@pataquets
Copy link

I have several items tagged view online and I can't search them using pocket-reader-search.
Looking at the code, query is split just by spaces alone, without any parsing for space-containing tags.
Possible solutions:

  • Interpret an escaped space, such as \SPC.
  • Account for tags enclosed in single/double quotes, by inhibiting space-splitting inside.
@alphapapa
Copy link
Owner

Thanks, this should be fixed, indeed. I don't know how soon I'll have time to work on this, so patches welcome.

@pataquets
Copy link
Author

Glad to hear it, thank you. Unfortunately, still novice Elisp'er here.
However, any directions on your preferred approach (UX and code-wise) and other advice you may provide will be appreciated and, maybe in the future it could be useful for me or others going thru this issue and ready to pick it up.
I've seen a handful of functions in the code needing love, which suggests me the issue should be broken in parts to qualify as "low hanging fruit" / "good first issue".

@alphapapa
Copy link
Owner

Glad to hear it, thank you. Unfortunately, still novice Elisp'er here.
However, any directions on your preferred approach (UX and code-wise)
and other advice you may provide will be appreciated and, maybe in the
future it could be useful for me or others going thru this issue and
ready to pick it up.

I don't have much advice about this. It should be relatively simple to parse the string given by the user for any segments enclosed in quotes. Since the syntax is basically Lisp syntax, you can probably use the READ function.

I've seen a handful of functions in the code needing love, which
suggests me the issue should be broken in parts to qualify as "low
hanging fruit" / "good first issue".

You'd have to be more specific about which functions you mean.

alphapapa added a commit that referenced this issue Sep 4, 2023
Fixes <#43>.

Reported-by: Alfonso Montero <https://github.com/pataquets>
@alphapapa
Copy link
Owner

@pataquets This should be fixed now. Please let me know if it works for you.

@pataquets
Copy link
Author

@alphapapa Tested. function works OK, thanks!
Filed related issue: #46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants