Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple players #20

Open
alphappy opened this issue Aug 31, 2024 · 2 comments
Open

Support for multiple players #20

alphappy opened this issue Aug 31, 2024 · 2 comments
Labels
priority: normal Normal priority type: enhancement New feature or request

Comments

@alphappy
Copy link
Owner

Add support for multiple players running macros simultaneously.

Possible designs:

  1. Add an optional flag to each line that indicates which player the line affects, default to 1 (or a macro-level default). This is incredibly cumbersome to write a macro and would require refactoring how exactly a macro tick is decided.
  2. Add an interface-level setting for deciding which player runs which macro. This requires making the library and macros non-static and makes the interface more complicated.
  3. Add an extension to >execute which allows specifying player. This requires making the library and macros non-static. >execute does not tick and so simultaneously running different macros for different players would not be complicated.
@alphappy alphappy added type: enhancement New feature or request priority: normal Normal priority labels Aug 31, 2024
@alphappy
Copy link
Owner Author

Dependent on #7

@RPink47
Copy link

RPink47 commented Sep 15, 2024

number 3 is probably the most viable, for number 1, the macro could remember which players were already ticked, and continue until it hits a player it already ticked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Normal priority type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants