Fix dependencies #17
Merged
Fix dependencies #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteodepalo
force-pushed
the
feature/mde/fix-dependencies
branch
10 times, most recently
from
500f9db
to
d999cb4
Compare
matteodepalo
force-pushed
the
feature/mde/fix-dependencies
branch
from
d999cb4
to
a60bb99
Compare
added 6 commits
August 10, 2015 15:26
matteodepalo
force-pushed
the
feature/mde/fix-dependencies
branch
from
412119b
to
e585354
Compare
|
👍 |
mcfiredrill
pushed a commit
to mcfiredrill/ember-calendar
that referenced
this pull request
Oct 7, 2018
pass navigation info when changing view (fixes alphasights#17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some dependencies issues found by #16
In particular:
ember-momentwas updated and along with itember-cli-moment-shimbecame a npm dependency, fixing an issue with the resolver not findingmoment.broccoli-sassas a dependency. We would like not to require sass or any style with this component, however we've found that without addingbroccoli-sassto your project dependencies, the component would break the build, complaining thatbroccoli-sassis not found. Ideally we would switch toember-cli-sassand make the dependency on sass optional. We'll try to do this in an upcoming PR.