Converting regular attributes from 'undefined' to 'null' #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rduarte-as
force-pushed
the
rdu/undefined-to-null
branch
from
28b5c9b
to
54e5f92
Compare
earaujoassis
approved these changes
Nov 14, 2019
rduarte-as
changed the title
rduarte-as
commented
Nov 14, 2019
| @@ -44,7 +44,7 @@ export default DS.JSONSerializer.extend(DS.EmbeddedRecordsMixin, { | |||
| payloadKey = this.keyForAttribute(key); | |||
| } | |||
|
|
|||
| json[payloadKey] = value; | |||
| json[payloadKey] = typeof value !== 'undefined' ? value : null; | |||
There was a problem hiding this comment.
Is there a better way to check for 'undefined' values?
|
I wonder if we should use the attribute's PS: Stopping to think about it, that's probably what EmberData is already doing. If it gets |
pedrovereza
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serializer is sending
undefinedin the graphql payload, which gets converted to"undefined"in the backendThis change should default to
nullwhenundefinedis present