Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gpg to image to support git verify-commit #48

Merged
merged 1 commit into from
Aug 23, 2022
Merged

added gpg to image to support git verify-commit #48

merged 1 commit into from
Aug 23, 2022

Conversation

Lerentis
Copy link
Contributor

hello there 馃憢

i tried to use this image in a CI way to check if the commit in question is verified. sadly this image does not contain a gpg package, which results in the following error:

git verify-commit $SHA
error: cannot run gpg: No such file or directory

adding gpg into the image makes it possible to use this git command:

git verify-commit $SHA
gpg: directory '/root/.gnupg' created
gpg: keybox '/root/.gnupg/pubring.kbx' created
gpg: Signature made Mon Aug 22 10:21:24 2022 UTC
gpg:                using RSA key $KEY

As this is now part of the standard git usage, i think gpg should be added to this image.

feel free to close this PR if you disagree with that 馃槂

@ozbillwang
Copy link
Contributor

LGTM

@ozbillwang ozbillwang merged commit 28966a5 into alpine-docker:master Aug 23, 2022
@Lerentis Lerentis deleted the feature/gpg-verify-support branch August 23, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants