Extend fix to elements with borders

alpinejs · Oct 9, 2021 · 2272be1 · 2272be1
1 parent 661027a
commit 2272be1
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/alpinejs/src/utils/on.js b/packages/alpinejs/src/utils/on.js
@@ -28,7 +28,11 @@ export default function on (el, event, modifiers, callback) {
         handler = wrapHandler(handler, (next, e) => {
             if (el.contains(e.target)) return
 
-            if (el.offsetWidth < 1 || el.offsetHeight < 1) return
+            if (el.offsetWidth < 1 && el.offsetHeight < 1) return
+
+            // Additional check for special implementations like x-collapse
+            // where the element doesn't have display: none
+            if (el._x_isShown === false) return
 
             next(e)
         })