Allow for using x-show with an important modifier #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the display property with the important property. This is useful for overriding classes which itself set the display property with !important
ryangjchandler
suggested changes
Jun 23, 2022
Co-authored-by: Ryan Chandler <ryangjchandler@gmail.com>
|
This is great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on this discussion.
There are cases where someone may use a class which itself sets the
displayproperty. If it is set with the!importantpropertyx-showstops working as expected because the class will always take precedence.This PR adds an
.importantmodifier tox-showwhich sets the inline style with!importantitself.I've added a test and updated the docs, please let me know if there are other changes needed :)