Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fixes x-model.fill when used with debounce #4103

Merged
merged 2 commits into from Mar 21, 2024

Conversation

ekwoka
Copy link
Contributor

@ekwoka ekwoka commented Mar 20, 2024

Fixes #4102

due to how debounce influenced the handling of the fill event, the model would clear out the input value before the event would be handled.

demo here

This instead just directly uses the same methods to update the value. These methods hadn't existed before, which is why the event was used before.

This isn't amazing, since it does not use any real Events, since it's impossible to make a real Event with a target value, and I was aiming for a minimal impact change.

Test is included.

@calebporzio
Copy link
Collaborator

Ok, that makes sense to me to just set that value directly instead of firing an event

@calebporzio calebporzio merged commit 4590592 into alpinejs:main Mar 21, 2024
1 check passed
@bb
Copy link
Contributor

bb commented Mar 21, 2024

Thank you, both!

@ekwoka
Copy link
Contributor Author

ekwoka commented Mar 22, 2024

@calebporzio Yes, originally, it used the event, due to how the logic for modifiers like number and different elements was handled in a way that wasn't able to be easily set directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants