✨ Enhances clicks with key modifiers #4209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekwoka
changed the title
|
Love this! Thanks @ekwoka! |
This was referenced Jun 12, 2024
This was referenced Jun 15, 2024
Open
Open
Open
Open
Open
Open
This was referenced Jun 22, 2024
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles #4208
Allows for the use of
ctrlmeta...etc keys on click and mouse event listeners.Overall simple change to include clicks
Would a more significant refactor also enable the use of mouse-button modifiers? Maybe...
This also solved some potential bugs related to modifiers that could exist on a keydown that wouldn't be properly ignored.
Includes: