fix(allow binding non string values to checkboxes) #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@calebporzio Hold off on this one for a second, just found an issue with these changes. |
|
@calebporzio Ready for review now - there was a problem where trying to bind an integer @KevinBatdorf originally found this problem too btw, in case he wanted to check if this fix works for him. From the new test, it looks like it will sort it out. |
|
Ok, thanks Ryan. Yeah, this seems like a bug and a good fix. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where non-string values couldn't be bound to a checkbox's value. An example would be trying to bind an integer / number:
The value of the checkbox would actually be "on" due to the typeof value === 'string' check inside of the checkbox handler. This PR replaces that check with a value truth check and makes sure that it's not a boolean, then casts the value to a string using String(value).
This could be done in user-land using x-bind:value="String(100)" or template literals x-bind:value="${value}" but I'd say that it's a bit of a bug with the framework.