Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newapkbuild: Checksum after adding build-steps #42

Closed
wants to merge 1 commit into from
Closed

newapkbuild: Checksum after adding build-steps #42

wants to merge 1 commit into from

Conversation

ganwell
Copy link

@ganwell ganwell commented Jul 14, 2018

The checksum used to be in the middle of APKBUILD files generated with
newapkbuild, because it was checksummed before adding the build-steps.

Discussion: I don't like the fact, that newapkbuild now swallows some abuild errors. So I am open to suggestions.

@nmeum
Copy link
Member

nmeum commented Sep 24, 2018

I think this is needed but I don't like the fact that all abuild errors caused by abuild fetch unpack are ignored now either.

@ganwell
Copy link
Author

ganwell commented Sep 27, 2018

@nmeum I added the version which first didn't push, because I thought it's too much magic.

The checksum used to be in the middle of APKBUILD files generated with
newapkbuild, because it was checksummed before adding the build-steps.
@ncopa
Copy link
Contributor

ncopa commented Oct 3, 2018

Since 1cbc853, i think we only need:

diff --git a/newapkbuild.in b/newapkbuild.in
index 19f822a..a3e16cf 100644
--- a/newapkbuild.in
+++ b/newapkbuild.in
@@ -339,6 +339,7 @@ __EOF__
 }
 
 __EOF__
+       abuild -f checksum
 }
 
 usage() {

algitbot pushed a commit that referenced this pull request Oct 3, 2018
@ncopa
Copy link
Contributor

ncopa commented Oct 3, 2018

fixed with 51830ef

@ncopa ncopa closed this Oct 3, 2018
@ganwell
Copy link
Author

ganwell commented Oct 3, 2018

confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants