-
Notifications
You must be signed in to change notification settings - Fork 691
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
testing/postgresql-pglogical: upgrade to 2.0.1
- Loading branch information
Showing
2 changed files
with
57 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
diff --git a/pglogical_apply_spi.c b/pglogical_apply_spi.c | ||
index 3eaccc4..111a4eb 100644 | ||
--- a/pglogical_apply_spi.c | ||
+++ b/pglogical_apply_spi.c | ||
@@ -454,7 +454,7 @@ static void | ||
pglogical_proccess_copy(pglogical_copyState *pglcstate) | ||
{ | ||
uint64 processed; | ||
- FILE *save_stdin; | ||
+ int save_stdin; | ||
|
||
if (!pglcstate->copy_parsetree || !pglcstate->copy_buffered_tuples) | ||
return; | ||
@@ -489,8 +489,16 @@ pglogical_proccess_copy(pglogical_copyState *pglcstate) | ||
* for this relation. Before that we save the current 'stdin' stream and | ||
* restore it back when the COPY is done | ||
*/ | ||
- save_stdin = stdin; | ||
- stdin = pglcstate->copy_read_file; | ||
+ save_stdin = dup(fileno(stdin)); | ||
+ if (save_stdin < 0) | ||
+ ereport(FATAL, | ||
+ (errcode_for_file_access(), | ||
+ errmsg("could not save stdin: %m"))); | ||
+ | ||
+ if (dup2(fileno(pglcstate->copy_read_file), fileno(stdin)) < 0) | ||
+ ereport(FATAL, | ||
+ (errcode_for_file_access(), | ||
+ errmsg("could not redirect stdin: %m"))); | ||
|
||
/* COPY may call into SPI (triggers, ...) and we already are in SPI. */ | ||
SPI_push(); | ||
@@ -501,10 +509,17 @@ pglogical_proccess_copy(pglogical_copyState *pglcstate) | ||
|
||
/* Clean up SPI state */ | ||
SPI_pop(); | ||
+ /* | ||
+ * Also close the read end of the pipe and restore 'stdin' to its original | ||
+ * value | ||
+ */ | ||
+ if (dup2(save_stdin, fileno(stdin)) < 0) | ||
+ ereport(FATAL, | ||
+ (errcode_for_file_access(), | ||
+ errmsg("could not restore stdin: %m"))); | ||
|
||
fclose(pglcstate->copy_read_file); | ||
pglcstate->copy_read_file = NULL; | ||
- stdin = save_stdin; | ||
|
||
/* Ensure we processed correct number of tuples */ | ||
Assert(processed == pglcstate->copy_buffered_tuples); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters