community/libcanberra: add pulseaudio support #10404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxice8
added
A-improve
Ikke
reviewed
Aug 24, 2019
|
On Fri Aug 23, 2019 at 10:55 PM Kevin Daudt wrote:
Ikke commented on this pull request.
> @@ -71,4 +65,11 @@ gtk3() {
"$subpkgdir"/usr/lib/gnome-settings-daemon-3.0/gtk-modules/
}
+pulse() {
Would it make sense to add an `isntall_if=` here so that it gets automatically installed when you have pulseaudio installed?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#10404 (review)
Added
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes GH-6936
@Ikke @ncopa