Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing/weston: change arch to "all" #1689

Closed
wants to merge 1 commit into from

Conversation

ollieparanoid
Copy link
Contributor

Changed arch to "all", so it can be built on aarch64 (and I see no reason, why it should not work on other architectures).
I did not increase the pkgrel, because a rebuild should not be necessary for this.

@ollieparanoid
Copy link
Contributor Author

This commit did not change anything regarding weston's check() function. Strange that it fails now. What is the policy here? Will this PR get accepted, regardless of this, or do I have to fix the testsuite (although I didn't change anything that could cause it to fail, meaning it must have failed before)?

Thanks!

@jirutka
Copy link
Member

jirutka commented Jun 15, 2017

I think that the tests in check phase failed even before, but it was ignored – we run abuild with set -e now.

@ollieparanoid
Copy link
Contributor Author

ollieparanoid commented Jun 15, 2017

That makes sense. I was able to get down to 7 failures of 23 tests with the following check function:

check() {
    export XDG_RUNTIME_DIR="$builddir/.xdg-runtime-dir"
    mkdir -p "$XDG_RUNTIME_DIR"
    mkdir -p "/tmp/.X11-unix/" # hardcoded in xwayland
    make -C "$builddir" check
}

Creating the /tmp/.X11-unix/ folder seems ugly to me though, do we really want to do this? I've noticed, that Arch does not have a check() function for weston, so this would be the easy way out.

Would it be acceptable to use !check in the APKBUILD?

@jirutka jirutka added the A-improve Improves an abuild label Jun 18, 2017
@kaniini
Copy link
Contributor

kaniini commented Jun 30, 2017

!check is probably ok for now, but we should fix the tests too, as the idea is to use tests as an early canary for finding breakages.

Disabled testsuite, as discussed here (with some workarounds, but I
could not get the full testsuite working):
alpinelinux#1689
@ollieparanoid
Copy link
Contributor Author

Okay, I did the lazy version with !check for now. I think the right way to fix this is talk to upstream (which I might do eventually).

@algitbot
Copy link

Merged in f243ef7 by @kaniini. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Jul 13, 2017
algitbot pushed a commit that referenced this pull request Jul 13, 2017
Disabled testsuite, as discussed here (with some workarounds, but I
could not get the full testsuite working):
#1689
samueldr pushed a commit to samueldr/pmaports that referenced this pull request Nov 17, 2018
Pull request for the same change in the upstream APKBUILD from Alpine:
alpinelinux/aports#1689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-improve Improves an abuild
Projects
None yet
4 participants