Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main/openrc: upgrade to 0.35.5 #3886

Closed
wants to merge 5 commits into from
Closed

Conversation

jirutka
Copy link
Member

@jirutka jirutka commented Apr 3, 2018

There’s one important change:

https://github.com/OpenRC/openrc/blob/master/NEWS.md:

In this version, the cgroups mounting logic has been moved from the sysfs service to the cgroups service. This was done so cgroups can be mounted inside an lxc/lxd container without using the other parts of the sysfs service.

?As a result of this change, if you are upgrading, you need to add cgroups to your sysinit runlevel by running the following command as root:

# rc-update add cgroups sysinit

I’m not sure what does it affect. Where is default set of services populated?

@jirutka jirutka added S-WIP Work in progress, don’t merge yet S-help-wanted Contributor needs help A-upgrade Upgrades an abuild labels Apr 3, 2018
@jirutka jirutka requested a review from ncopa April 3, 2018 15:51
@ncopa
Copy link
Contributor

ncopa commented Apr 3, 2018

I think this is something that is sort of expected to be mounted, like /sys itself. It seems like openrc itself can set limits on services it manages, so openrc itself may need it.

Default services are set up on first boot in initramfs-init: https://git.alpinelinux.org/cgit/mkinitfs/tree/initramfs-init.in#n506 and then copied over with setup-disk.

One way to do it would be to have a pre-install/update script that checks if sysfs service is started and if it is, create a symlink in /etc/runlevels/sysinit.

I don't think many things will break if its not missing, but it is difficult to know for sure.

@ncopa
Copy link
Contributor

ncopa commented Apr 3, 2018

looks like community/cgmanager/cgmanager.initd also needs cgroups.

@clandmeter
Copy link
Member

clandmeter commented Apr 23, 2018

Are we going to do this for 3.8?
Looks like we are many releases behind.

ps, why is only the subject of this PR 0.36?

@@ -44,6 +43,8 @@ build() {
}

package() {
local i
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget about $j

The cgroups mounting logic has been moved from the sysfs service to
the cgroups service in OpenRC 0.35.
The cgroups mounting logic has been moved from the sysfs service to
the cgroups service in OpenRC 0.35
The cgroups mounting logic has been moved from the sysfs service to
the cgroups service in OpenRC 0.35.
@jirutka
Copy link
Member Author

jirutka commented Apr 23, 2018

It seems like openrc itself can set limits on services it manages, so openrc itself may need it.

Cgroups support is optionally, OpenRC can work even without it.

Are we going to do this for 3.8?

I’d like to, ’cause we’re many releases behind.

ps, why is only the subject of this PR 0.36?

??

@algitbot
Copy link

Merged in dbbb3d0, 25ebbc9, 535f4ab, cbc1123, a667b79 by @ncopa. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Apr 23, 2018
@clandmeter
Copy link
Member

@jirutka your patches are for openrc 0.35.5 while the subject says 0.36 which is the latest version.

@jirutka
Copy link
Member Author

jirutka commented Apr 23, 2018

your patches are for openrc 0.35.5 while the subject says 0.36 which is the latest version.

Huh, I have no idea why I did that. It’s most likely a mistake.

@jirutka jirutka deleted the openrc-0.36 branch April 23, 2018 21:01
@jirutka jirutka changed the title main/openrc: upgrade to 0.36 main/openrc: upgrade to 0.35.5 Apr 23, 2018
@jirutka
Copy link
Member Author

jirutka commented Apr 23, 2018

Aha, 0.36 has not been released yet. But still I don’t know why I wrote 0.36 into the PR’s title.

@clandmeter
Copy link
Member

hmm, i think because its listed in https://github.com/OpenRC/openrc/blob/master/NEWS.md

jirutka added a commit to alpinelinux/alpine-make-vm-image that referenced this pull request Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-upgrade Upgrades an abuild S-help-wanted Contributor needs help S-WIP Work in progress, don’t merge yet
Projects
None yet
4 participants