Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community/emacs: modernize #7408

Closed
wants to merge 2 commits into from
Closed

community/emacs: modernize #7408

wants to merge 2 commits into from

Conversation

maxice8
Copy link
Contributor

@maxice8 maxice8 commented Apr 28, 2019

  • Fix license
  • Remove deprecated gconf dependency

@probot-autolabeler probot-autolabeler bot added the R-community Community repository label Apr 28, 2019
@Ikke
Copy link
Contributor

Ikke commented May 3, 2019

Build fails due to segfault:

Dumping under the name emacs

Warning: Your system has a gap between BSS and the
heap (33088543 bytes). This usually means that exec-shield
or something similar is in effect. The dump may
fail because of this. See the section about
exec-shield in etc/PROBLEMS for more information.

6796416 of 16777216 static heap bytes used
make[1]: *** [Makefile:740: bootstrap-emacs] Segmentation fault (core dumped)

@Ikke Ikke added A-improve Improves an abuild S-broken This patch is broken, must not be merged labels May 3, 2019
@tcely tcely added this to Pending in Triage May 17, 2019
TBK
TBK reviewed May 25, 2019
View reviewed changes
community/emacs/APKBUILD Outdated
@@ -10,7 +10,7 @@ depends="emacs-nox"
url="https://www.gnu.org/software/emacs/emacs.html"
license="GPL-3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPDX identifier needed.

@TBK
Copy link
Contributor

TBK commented May 25, 2019 •
edited

Is the issue related to https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23529 ?

@maxice8
Copy link
Contributor Author

maxice8 commented May 25, 2019

apparently yes.

@maxice8
Copy link
Contributor Author

maxice8 commented May 25, 2019

No, works here, must be some configuration on CI-side ?

@Ikke Ikke added T-ci-malfunction Travis malfunction, must be built locally by developer and removed S-broken This patch is broken, must not be merged labels May 26, 2019
@Ikke
Copy link
Contributor

Ikke commented May 26, 2019

This built fine locally. After googling, it might have to do with either docker, or some kernel setting /proc/sys/kernel/randomize_va_space.

@algitbot
Copy link

Merged in c875a82, cc2af8d by @Ikke. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this May 26, 2019
Triage automation moved this from Pending to Done May 26, 2019
algitbot pushed a commit that referenced this pull request May 26, 2019
@maxice8 @Ikke
community/emacs: drop obsolete gconf-dev dependency
c875a82 
Closes GH-7408
algitbot pushed a commit that referenced this pull request May 26, 2019
@maxice8 @Ikke
community/emacs: modernize
cc2af8d 
Closes GH-7408
@maxice8 maxice8 deleted the emacs branch May 26, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TBK TBK TBK left review comments

Assignees
No one assigned
Labels
A-improve Improves an abuild R-community Community repository T-ci-malfunction Travis malfunction, must be built locally by developer
Projects
Triage
Done
Milestone
No milestone
4 participants
@maxice8 @Ikke @TBK @algitbot