main/bash-completion: update to 2.9

[ghost]

Added bash-completion-dev subpackage.

Builders will fail on the revbumped packages in community/testing due to the new package in main.

Kept cd "$builddir" since I recently learned that existing main/ packages should have these for potential backports.

Previously opened as #7810, but a new PR opened due to branch name change.

[tcely]

Would it be possible to move all of these to community instead?

A quick check makes me think dconf, libvirt and bash-completion will be able to move to community so we don't need to pull py-pexpect, py-ptyprocess, and psmisc into main.

[ghost]

Would it be possible to move all of these to community instead?

A quick check makes me think dconf, libvirt and bash-completion will be able to move to community so we don't need to pull py-pexpect, py-ptyprocess, and psmisc into main.

I think people would like security patches for libvirt for more than 6 months: https://www.cvedetails.com/product/20594/Redhat-Libvirt.html?vendor_id=25

Initially I tried moving it to community though.

[ghost]

I recently learned that patchwork also has a patch to update to 2.9: https://patchwork.alpinelinux.org/patch/4849/.

The ABUILD diff on patchwork needs to be modernized. I think the test system changes are a bit invasive - in the PR here I opted to delete those tests. It's also missing some of the cleanups (like removing completions that no longer conflict).

From it I found scop/bash-completion#318 which potentially could be applied.

[oxr463]

Greetings,

I am the maintainer for bash-completion. I have been working with upstream to nail down a few bugs with the test suite so it took a bit to get a new revision bump ready.

I'm cool with whatever happens, but in the future it would be nice to get a heads up so that I don't waste time duplicating work.

Cheers,

[tcely]

Hi @oxr463

You might be interested in #7236 as that would assign you to PRs that change anything in the bash-completion subdirectory.

[tcely]

Would it be possible to move all of these to community instead?
A quick check makes me think dconf, libvirt and bash-completion will be able to move to community so we don't need to pull py-pexpect, py-ptyprocess, and psmisc into main.

I think people would like security patches for libvirt for more than 6 months: https://www.cvedetails.com/product/20594/Redhat-Libvirt.html?vendor_id=25

Personally, I'm in favor of moving bash-completion to community even if that means removing completion support from libvirt entirely.

[oxr463]

Thanks for the link! I guess I'll just wait and see what happens next.

[ghost]

Sorry for not notifying you @oxr463. I spent 15min on this, so I’m not concerned about wasted effort on my end.

In the ML/PW workflow I would just add your email to CC when posting to the list. With github though it’s hard to find the maintainers GH handle.

Maybe #7236 will help, but as it stands it would not help for this PR.

[maxice8]

• for file community/colord/APKBUILD:

GPL-2.0 is ambiguous and not SPDX compliant
builddir= has default value, remove

• for file community/notmuch/APKBUILD:

GPL-3.0 is ambiguous and not SPDX compliant
builddir= can be removed

• for file main/bash-completion/APKBUILD:

builddir= can be removed

• for file main/dconf/APKBUILD:

builddir has default value

• for file main/libvirt/APKBUILD:

LGPL is ambiguous and not SPDX compliant
builddir= can be removed

• for file main/psmisc/APKBUILD:

BSD is ambiguous and not SPDX compliant
GPL is ambiguous and not SPDX compliant
empty variables can be removed
builddir= can be removed

• for file main/py-ptyprocess/APKBUILD:

|| return 1 can be removed
empty variables can be removed

• for file testing/createrepo_c/APKBUILD:

GPL-2.0 is not SPDX compliant
builddir= can be removed

[ghost]

@maxice8 I was under the impression that packages in main/ should not be modernized to facilitate easier backporting of sec fixes.

As for the licenses I think those changes could be better handled outside this PR which is large enough as it stands.

[maxice8]

On Tue, May 21, 2019 at 11:33:04PM -0700, Eivind Uggedal wrote: @maxice8 I was under the impression that packages in `main/` should not be modernized to facilitate easier backporting of sec fixes.

Just removal of cd "$builddir" since the old supported versions of alpine abuild's don't have that change yet

As for the licenses I think those changes could be better handled outside this PR which is large enough as it stands.

ok

…

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #7873 (comment)

[maxice8]

LGTM

[stale]

Sorry to bother you, but we noticed there has't been any activity on this
pull request for 60 days. Because we have to deal with a lot of pull
requests, we use this stupid bot to automatically mark it as stale.

If you still want this PR to be merged, you can do the following:

1. Rebase the PR on the latest master.
2. Apply any feedback you might have received.
3. Make sure the package builds without issues in CI.
4. If the PR is waiting on us, feel free to ping one of us here or on IRC.

If you are no longer interested in this PR, you don't have to do anything.
The PR will automatically be closed in 14 days.

[stale]

This pull request has been automatically closed.

[oxr463]

Please re-open this. Even after all of this, it turns out that this package has still not been update. My request on patchwork is still open as well, (See: https://patchwork.alpinelinux.org/patch/4849).