Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community/gomplate: upgrade to 3.5.0 #8360

Closed
wants to merge 2 commits into from
Closed

community/gomplate: upgrade to 3.5.0 #8360

wants to merge 2 commits into from

Conversation

hairyhenderson
Copy link
Contributor

@hairyhenderson
community/gomplate: upgrade to 3.5.0
2a40c23 
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
@probot-autolabeler probot-autolabeler bot added the R-community Community repository label Jun 1, 2019
@project-bot project-bot bot added this to To Do in Triage Jun 1, 2019
maxice8
maxice8 requested changes Jun 1, 2019
View reviewed changes
Copy link
Contributor

@maxice8 maxice8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For community/gomplate/APKBUILD

|| return 1 can be removed
cd "$builddir" can be removed
remove the ./bin/gomplate check

Triage automation moved this from To Do to Review in progress Jun 1, 2019
@hairyhenderson
Copy link
Contributor Author

Thanks @maxice8 - will address.

@hairyhenderson
[community/gomplate] cleaning up APKBUILD based on review comments
ad3d6ba 
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
@hairyhenderson
Copy link
Contributor Author

@maxice8 addressed - PTAL

maxice8
maxice8 approved these changes Jun 1, 2019
View reviewed changes
Copy link
Contributor

@maxice8 maxice8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@algitbot
Copy link

algitbot commented Jun 1, 2019

Merged in 7561c8b, 6c73f51 by @Ikke. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Jun 1, 2019
Triage automation moved this from Review in progress to Done Jun 1, 2019
algitbot pushed a commit that referenced this pull request Jun 1, 2019
@hairyhenderson @Ikke
community/gomplate: upgrade to 3.5.0
7561c8b 
Signed-off-by: Dave Henderson <dhenderson@gmail.com>

Closes GH-8360
algitbot pushed a commit that referenced this pull request Jun 1, 2019
@hairyhenderson @Ikke
community/gomplate: modernize
6c73f51 
Signed-off-by: Dave Henderson <dhenderson@gmail.com>

Closes GH-8360
@hairyhenderson hairyhenderson deleted the upgrade-gomplate-aport-3.5.0 branch June 2, 2019 00:33
algitbot pushed a commit that referenced this pull request Apr 1, 2020
@fabled
lua: fix build and update to lua5.3
0b82bcc 
Fixes #8360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxice8 maxice8 maxice8 approved these changes

Assignees
No one assigned
Labels
R-community Community repository
Projects
Triage
Done
Milestone
No milestone
3 participants
@hairyhenderson @algitbot @maxice8