community/tclx: remove use of rresvport #849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved from main to community. This code is similar to the perl support packages in community. Fixed whitespace and indentation issues. Renamed _builddir to builddir.
WAT? This is not Debian… o.O |
jirutka
reviewed
Feb 9, 2017
community/tclx/APKBUILD
Outdated
| prepare() { | ||
| cd "$builddir" | ||
| default_prepare | ||
| } |
There was a problem hiding this comment.
Why have you added this? default_prepare is called by default when custom prepare function is not defined.
There was a problem hiding this comment.
I used main/openssh as an example. I cut and pasted the prepare, but after removing one line I did not understand to remove the entire block.
jirutka
changed the title
|
Applied with pkgrel bump in commit 1ab30ef. I had to merge manually using the diff because this was on top of your earlier tree, and not on top of the aports master. Please submit further changes rebased on top of the aports master branch. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of network routines in libc on Debian. In this case rresvport is just a helper to allocate a port < 1024. The user can do that as root.