Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing/mongo-c-driver: APKBUILD cleanup #9273

Closed
wants to merge 1 commit into from
Closed

testing/mongo-c-driver: APKBUILD cleanup #9273

wants to merge 1 commit into from

Conversation

sergey-safarov
Copy link
Contributor

No description provided.

@project-bot project-bot bot added this to To Do in Triage Jul 3, 2019
@probot-autolabeler probot-autolabeler bot added the R-testing Testing repository label Jul 3, 2019
This was referenced Jul 3, 2019
Merged
Closed
@andypost
Copy link
Contributor

andypost commented Jul 4, 2019

This port already exists https://github.com/alpinelinux/aports/tree/master/non-free/mongo-c-driver

@probot-autolabeler probot-autolabeler bot added the R-non-free Non-free repository label Jul 5, 2019
@sergey-safarov
Copy link
Contributor Author

Hi @andypost
According 8a901de commit message. Changed MongoDB and all related packages moved to non-free folder.
Think mongo-c-driver moved by mistake. This package have own Apache 2.0 licence.
I will move this package back and update packaging to 1.14.0 version.

Also question.
How i can install non-free packages?

@sergey-safarov sergey-safarov force-pushed the mongo-c-driver branch 2 times, most recently from 2b90083 to f7e5b9c Compare July 6, 2019 07:37
sergey-safarov added a commit to sergey-safarov/aports that referenced this pull request Jul 6, 2019
@sergey-safarov
mongo-c-driver: reverted part of 8a901de commit
bd38d3c 
mongo-c-driver use Apache 2.0 license. Details as alpinelinux#9273
@sergey-safarov
Copy link
Contributor Author

Think all is resolved.
If possible merge without squashing commits.

@tcely

This comment has been minimized.

Sign in to view
Triage automation moved this from To Do to Reviewer approved Jul 6, 2019
tcely
tcely reviewed Jul 6, 2019
View reviewed changes
Copy link
Collaborator

@tcely tcely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely optional, but a good practice anyway.

testing/mongo-c-driver/APKBUILD Outdated Show resolved Hide resolved
testing/mongo-c-driver/APKBUILD Outdated Show resolved Hide resolved
@sergey-safarov sergey-safarov force-pushed the mongo-c-driver branch 2 times, most recently from f2b50c4 to 6b88632 Compare July 6, 2019 09:07
@tcely tcely added A-improve Improves an abuild A-move Moves abuild between repositories A-upgrade Upgrades an abuild labels Jul 6, 2019
@sergey-safarov sergey-safarov mentioned this pull request Jul 6, 2019
Closed
@tcely tcely mentioned this pull request Jul 16, 2019
Closed
@maxice8
Copy link
Contributor

maxice8 commented Jul 22, 2019

Can be closed

@tcely
Copy link
Collaborator

tcely commented Jul 22, 2019

@maxice8 is there a reason you chose to merge the unreviewed patch instead of this one? Wasn't CI failing in the other pull request or was that corrected?

@maxice8
Copy link
Contributor

maxice8 commented Jul 22, 2019

Yes, it was reviewed and a more correct commit title

@sergey-safarov
Copy link
Contributor Author

PR rebased on current master

@sergey-safarov sergey-safarov changed the title testing/mongo-c-driver: new aport testing/mongo-c-driver: APKBUILD cleanup Jul 22, 2019
@maxice8
Copy link
Contributor

maxice8 commented Aug 4, 2019

Conflicts with master, also removes libbson and its subpackages.

Most changes were already merged.

Triage automation moved this from Reviewer approved to Done Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcely tcely tcely approved these changes

Assignees
No one assigned
Labels
A-improve Improves an abuild A-move Moves abuild between repositories A-upgrade Upgrades an abuild R-non-free Non-free repository R-testing Testing repository
Projects
Triage
Done
Milestone
No milestone
4 participants
@sergey-safarov @andypost @tcely @maxice8