Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More validation and refactor #22

Merged
merged 8 commits into from
Nov 16, 2020
Merged

More validation and refactor #22

merged 8 commits into from
Nov 16, 2020

Conversation

koriym
Copy link
Member

@koriym koriym commented Nov 16, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 16, 2020

Codecov Report

Merging #22 (dcbf6f9) into master (60c0787) will increase coverage by 1.36%.
The diff coverage is 97.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
+ Coverage     96.80%   98.16%   +1.36%     
- Complexity      139      144       +5     
============================================
  Files            14       13       -1     
  Lines           375      381       +6     
============================================
+ Hits            363      374      +11     
+ Misses           12        7       -5     
Flag Coverage Δ Complexity Δ
php 98.16% <97.77%> (+1.36%) 0.00 <15.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/DumpDocs.php 98.86% <ø> (ø) 26.00 <0.00> (?)
src/Link.php 100.00% <ø> (+14.28%) 3.00 <0.00> (-2.00) ⬆️
src/TransDescriptor.php 100.00% <ø> (+21.42%) 4.00 <0.00> (-1.00) ⬆️
src/DrawDiagram.php 96.15% <83.33%> (ø) 18.00 <1.00> (?)
src/AlpsProfile.php 96.25% <100.00%> (+0.47%) 37.00 <5.00> (+6.00)
src/DescriptorScanner.php 100.00% <100.00%> (+3.22%) 23.00 <6.00> (+4.00)
src/Edge.php 100.00% <100.00%> (ø) 9.00 <1.00> (ø)
src/IndexPage.php 100.00% <100.00%> (ø) 4.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60c0787...dcbf6f9. Read the comment docs.

@koriym koriym merged commit 2555716 into master Nov 16, 2020
@koriym koriym deleted the more-validation branch November 16, 2020 17:55
@koriym koriym linked an issue Nov 16, 2020 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error handling/message
2 participants