Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grade: Exceeds Expectations #5

Closed
Rodrigap opened this issue Apr 11, 2018 · 1 comment
Closed

Grade: Exceeds Expectations #5

Rodrigap opened this issue Apr 11, 2018 · 1 comment

Comments

@Rodrigap
Copy link

Really nice job on this project! Your app works great and your codebase is one of the more creative ones I've seen for this project. I love that you added extra features, like the ability to search on enter and the removal of the playlist tracks from the search results. The second feature has a couple of minor bugs, but it's still great that you included it. My biggest critique is that I didn't love how you separated components versus containers, but that could just be a personal preference. Overall, this was really creative and well done! Great job

@Alrefai
Copy link
Owner

Alrefai commented Apr 11, 2018

Thanks for your delightful review. I am honored!

Regarding components versus containers, I thought that was a good practice. I have learned that in one of the advanced React courses in Codecademy. However, I understand your point of view. This is a simple app and I should have kept it simple. I was just excited to put what I have learned into practice.

P.S. that bug is fixed. Please refer to issue #4.

@Alrefai Alrefai closed this as completed Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants