Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the mess #2

Merged
merged 1 commit into from
Nov 8, 2012
Merged

Clean up the mess #2

merged 1 commit into from
Nov 8, 2012

Conversation

sindresorhus
Copy link
Contributor

  • Fix naming scheme
  • Remove duplicates
  • Losslessly minify them all

Fixes #1

@paulirish
Copy link
Contributor

Question for everyone: is it useful to have 16, 32, 64, etc pixel versions?

I think we should just host the 512s and let folks scale themselves.

@paulirish
Copy link
Contributor

Also I don't think we can do "all" without including mobile browsers, of which the logo situation is a mess.

@sindresorhus
Copy link
Contributor Author

Question for everyone: is it useful to have 16, 32, 64, etc pixel versions?

I think we should keep the 128, 256 and 512 versions, now that we have HiDPI to care about, we should even have 1024 versions.

I think we should just host the 512s and let folks scale themselves.

People could do that, but it's nice to have some common defaults, so they don't have to.

Also I don't think we can do "all" without including mobile browsers, of which the logo situation is a mess.

Let's call it all-desktop then?

@JoshuaJones
Copy link

What about breaking it down into folders for each browser? So going into the "Chrome" directory would list out all the common sizes we'd need?

@paulirish
Copy link
Contributor

I'd rather drop everything but the 512's (except for webkit or any other
cases where we only have the best we can get)

Easier to manage canonical assets when you aren't managing multiple
arbitrary resolutions.

On Wed, Nov 7, 2012 at 2:02 PM, Joshua Jones notifications@github.comwrote:

What about breaking it down into folders for each browser? So going into
the "Chrome" directory would list out all the common sizes we'd need?


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-10167065.

@sindresorhus
Copy link
Contributor Author

Done :)

paulirish added a commit that referenced this pull request Nov 8, 2012
@paulirish paulirish merged commit dfd18e8 into alrra:master Nov 8, 2012
@paulirish
Copy link
Contributor

🆗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old logos
3 participants