alsa-gobject: seq: tstamp: use wrapper structure instead of union #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In UAPI for ALSA Sequencer, snd_seq_timestamp is union with
snd_seq_tick_time_t and struct snd_seq_real_time types. The
libalsaseq has GLib Boxed object for the union, named as
ALSASeqTstamp.
```
$ cat build/src/seq/ALSASeq-0.0.gir
...
<union name="Tstamp"
c:type="ALSASeqTstamp"
glib:type-name="ALSASeqTstamp"
glib:get-type="alsaseq_tstamp_get_type"
c:symbol-prefix="tstamp">
<source-position filename="../src/seq/tstamp.h" line="14"/>
...
</union>
...
```
Although this is valid in a view of GObject
Introspection, it's not nesessarily convenient to language
bindings because some programming language doesn't support
union type. In this case, the type is not available.
This commit adds an alternative structure to wrap the union.
As a result, ALSASeqTstamp is GLib Boxed object for the
wrapper structure.
```
$ cat build/src/seq/ALSASeq-0.0.gir
...
<record name="Tstamp"
c:type="ALSASeqTstamp"
glib:type-name="ALSASeqTstamp"
glib:get-type="alsaseq_tstamp_get_type"
c:symbol-prefix="tstamp">
<source-position filename="../src/seq/tstamp.h" line="18"/>
<field name="tstamp" writable="1">
<type name="gpointer" c:type="snd_seq_timestamp"/>
</field>
...
</record>
...
```
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit renames argument for real time so that the name is consistent within the library. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit renames argument for real time so that the name is consistent within the library. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In UAPI for ALSA Sequencer, snd_seq_timestamp is union with
snd_seq_tick_time_t and struct snd_seq_real_time types. The
libalsaseq has GLib Boxed object for the union, named as
ALSASeqTstamp.
Although this is valid in a view of GObject
Introspection, it's not necessarily convenient to language
bindings because some programming language doesn't support
union type. In this case, the type is not available.
This commit adds an alternative structure to wrap the union.
As a result, ALSASeqTstamp is GLib Boxed object for the
wrapper structure.