[PATCH 0/5] seq: add interface for queue timer #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: ed31386 ("doc: change URL for help pages") Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
In UAPI of ALSA Sequencer, queue timer is expressed by union to support several types of backend timer. This commit adds common interface for the timer. It should implements two properties; the identifier of queue and the type of timer. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
…Timer One of the backend timer for queue is an instance of timer in ALSA Timer. This commit adds gobject class for the type of queue timer. It has two properties; the identifier of timer and the count of ticks as resolution. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Current implementation to handle queue timer is by ALSASeq.QueueTimer gobject class, and uses boxed object (=structure) to express actual data of the timer. The implementation is not necessarily convenient to add more type of queue timer since it requires to add getter/setter of data to the class. This commit uses ALSASeq.QueueTimerCommon interface to handle any type of queue timer in ALSASeq.UserInstance for system call. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
The former commit made some gobject classes as unused. This commit deletes them. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation uses function of QueueTimer to retrieve data for variants of
queue timer, however it's not enough convenient in the case of language bindings.
The usage of GObject.Value in object property is expected to be supported widely
instead.
This patchset uses object classes derived from GObject to express the variants.
The common properties are expressed by QueueTimerCommon interface. The
ALSATimer variant is currently supported to implement the interface.