Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH 00/11] ctl: elem-value: rewrite getter methods #79

Merged
merged 11 commits into from
Jun 26, 2022

Conversation

takaswie
Copy link
Member

This patchset rewrites getter methods of ALSACtl.ElemValue so that they just return
pointer of internal storage instead of copying to user buffer.

Takashi Sakamoto (11):
  timer: fix entry in exported symbol map
  ctl: elem-value: clear value field at setter method
  ctl: elem-value: rewrite getter for boolean values
  ctl: elem-value: rewrite getter for 32 bit signed integer values
  ctl: elem-value: rewrite getter for enumeration index values
  ctl: elem-value: rewrite getter for 8 bit unsigned integer values
  ctl: elem-value: rewrite getter for IEC 60958 channel status
  ctl: elem-value: rewrite getter for IEC 60958 user data
  ctl: elem-value: rewrite getter for 64 bit signed integer values
  ctl: elem-value: update class description
  update README with compatibility note

 README.rst              | 124 ++++++++++++++++++++++++++++++--
 samples/ctl             |  11 ++-
 src/ctl/alsactl.map     |  15 ++--
 src/ctl/elem-value.c    | 152 +++++++++++++++++++++-------------------
 src/ctl/elem-value.h    |  14 ++--
 src/timer/alsatimer.map |   3 +-
 6 files changed, 218 insertions(+), 101 deletions(-)

Fixes: b4e62cd ("timer: instance-status: rename method with real time")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
For safe at reuse of the boxed structure.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit rewrites the getter method so that it returns a pointer to
internal storage for boolean values.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit rewrites the getter method so that it returns a pointer to
internal storage for 32 bit signed integer values.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit rewrites the getter method so that it returns a pointer to
internal storage for enumeration index values.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit rewrites the getter method so that it returns a pointer to
internal storage for 8 bit unsigned integer values.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit rewrites the getter method so that it returns a pointer to
internal storage for IEC 60958 channel status.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit rewrites the getter method so that it returns a pointer to
internal storage for IEC 60958 user data.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This commit rewrites the getter method so that it returns a pointer to
internal storage for 64 bit signed integer values.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
@takaswie takaswie added the enhancement New feature or request label Jun 25, 2022
@takaswie takaswie requested a review from a team June 25, 2022 03:35
@takaswie takaswie self-assigned this Jun 25, 2022
@takaswie takaswie merged commit 6ae7225 into master Jun 26, 2022
@takaswie takaswie deleted the topic/ctl-refactor branch June 26, 2022 07:08
@takaswie
Copy link
Member Author

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant