Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sof topology compilation fails #114

Closed
juimonen opened this issue Jan 20, 2021 · 2 comments
Closed

sof topology compilation fails #114

juimonen opened this issue Jan 20, 2021 · 2 comments

Comments

@juimonen
Copy link

sof topologies fail to compile because of following commit:

commit 51e1d48
Author: Jaroslav Kysela perex@perex.cz
Date: Thu Jan 7 17:40:42 2021 +0100

topology: parse_tuple_set() - remove dead condition code

Signed-off-by: Jaroslav Kysela <perex@perex.cz>

I don't completely understand the change...? we are in "case SND_SOC_TPLG_TUPLE_TYPE_WORD" and then we check for SND_SOC_TPLG_TUPLE_TYPE_WORD (and not the value anymore) and error out?
@juimonen
Copy link
Author

@perexg FYI

perexg added a commit that referenced this issue Jan 20, 2021
@perexg
topology: fix 'parse_tuple_set() - remove dead condition code'
ae7362c 
The whole SND_SOC_TPLG_TUPLE_TYPE_WORD condition part must be
commented out, otherwise the condition is always true.

Fixes: 51e1d48 ("topology: parse_tuple_set() - remove dead condition code")
BugLink: #114
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
@perexg
Copy link
Member

perexg commented Jan 20, 2021

Yes, my fault. The fix is above. Thank you for your report.

@perexg perexg closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juimonen @perexg