Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double snd_dlobj_unlock() #181

Closed
johado opened this issue Oct 7, 2021 · 1 comment
Closed

Double snd_dlobj_unlock() #181

johado opened this issue Oct 7, 2021 · 1 comment

Comments

@johado
Copy link

johado commented Oct 7, 2021

In dlmisc.c:snd_dlobj_cache_get0() there is a call to snd_dlobj_unlock() in the __err: path which should not be there.
All lock/unlock are done by the callers to this function.

--- a/src/dlmisc.c
+++ b/src/dlmisc.c
@@ -359,7 +359,6 @@ snd_dlobj_cache_get0(const char *lib, const char *name,
                free(c);
              __err:
                snd_dlclose(dlobj);
-               snd_dlobj_unlock();
                return NULL;
        }
        c->dlobj = dlobj;
johado added a commit to johado/alsa-lib that referenced this issue Oct 7, 2021
Remove call to snd_dlobj_unlock() in snd_dlobj_cache_get0()
All lock/unlock is done by callers of the function.

Fixes: alsa-project#181
perexg pushed a commit that referenced this issue Oct 7, 2021
Remove call to snd_dlobj_unlock() in snd_dlobj_cache_get0()
All lock/unlock is done by callers of the function.

Buglink: #181
Fixes: #182
Signed-off-by: Johan Adolfsson <johana@axis.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
@perexg
Copy link
Member

perexg commented Oct 7, 2021

Fixed via #182 . Thank you.

@perexg perexg closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants