Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linking failure when using separate builddir #382

Closed
jpalus opened this issue Jan 30, 2024 · 1 comment
Closed

Linking failure when using separate builddir #382

jpalus opened this issue Jan 30, 2024 · 1 comment

Comments

@jpalus
Copy link
Contributor

jpalus commented Jan 30, 2024

If $(builddir) is different than $(srcdir) linking of libatopology fails:

$ mkdir builddir
$ cd builddir
$ ../configure
...
$ make
...
/usr/bin/ld: cannot open linker script file Versions: No such file or directory

alsa-lib 1.2.11
jpalus added a commit to jpalus/alsa-lib that referenced this issue Jan 30, 2024
@jpalus
topology: correct version script path
5387a33 
contrary to libasound, version script for libatopology is a regular
source file. while it's often the case that $(builddir) and $(srcdir)
point to the same directory, they don't always have to. therefore path
needs to point explicitly to $(srcdir) for Versions script in topology

Fixes: alsa-projectGH-382
Fixes: dc7da76 ("topology: separate Versions linker script")
Signed-off-by: Jan Palus <jpalus@fastmail.com>
@jpalus jpalus mentioned this issue Jan 30, 2024
Closed
@perexg perexg closed this as completed in 2a736a0 Jan 30, 2024
@ryandesign ryandesign mentioned this issue Mar 14, 2024
Closed
@ryandesign
Copy link
Contributor

How could a release have been shipped with such a bug? Don't you test out-of-source builds?

Why hasn't there been a new release containing the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

topology: correct version script path jpalus/alsa-lib
2 participants
@ryandesign @jpalus