Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error after 6d06fcc2 (a typo?) #85

Closed
asavah opened this issue Oct 14, 2020 · 1 comment
Closed

Build error after 6d06fcc2 (a typo?) #85

asavah opened this issue Oct 14, 2020 · 1 comment

Comments

@asavah
Copy link
Contributor

asavah commented Oct 14, 2020

After 6d06fcc the build fails.

Some insightful warnings:

pcm_dmix.c: In function ‘snd_pcm_dmix_rewind’:
pcm_dmix.c:719:9: warning: implicit declaration of function ‘pcm_frames_diff’; did you mean ‘pcm_frame_diff’? [-Wimplicit-function-declaration]
  719 |  size = pcm_frames_diff(dmix->last_appl_ptr, dmix->appl_ptr, pcm->boundary);
      |         ^~~~~~~~~~~~~~~
      |         pcm_frame_diff
pcm_dshare.c: In function ‘snd_pcm_dshare_sync_area’:
pcm_dshare.c:115:9: warning: implicit declaration of function ‘pcm_frames_diff’; did you mean ‘pcm_frame_diff’? [-Wimplicit-function-declaration]
  115 |  size = pcm_frames_diff(dshare->appl_ptr, dshare->last_appl_ptr, pcm->boundary);
      |         ^~~~~~~~~~~~~~~
      |         pcm_frame_diff
pcm_dsnoop.c: In function ‘snd_pcm_dsnoop_sync_ptr’:
pcm_dsnoop.c:155:9: warning: implicit declaration of function ‘pcm_frames_diff’; did you mean ‘pcm_frame_diff’? [-Wimplicit-function-declaration]
  155 |  diff = pcm_frames_diff(slave_hw_ptr, old_slave_hw_ptr, dsnoop->slave_boundary);
      |         ^~~~~~~~~~~~~~~
      |         pcm_frame_diff

The error itself:

/home/asavah/kross/host/asusb450eg/lib/gcc/x86_64-asusb450eg-linux-gnu/10.2.1/../../../../x86_64-asusb450eg-linux-gnu/bin/ld: pcm/.libs/libpcm.a(pcm_dmix.o): in function `snd_pcm_dmix_rewind':
pcm_dmix.c:(.text+0x1c8f): undefined reference to `pcm_frames_diff'
/home/asavah/kross/host/asusb450eg/lib/gcc/x86_64-asusb450eg-linux-gnu/10.2.1/../../../../x86_64-asusb450eg-linux-gnu/bin/ld: pcm_dmix.c:(.text+0x1ce7): undefined reference to `pcm_frames_diff'
/home/asavah/kross/host/asusb450eg/lib/gcc/x86_64-asusb450eg-linux-gnu/10.2.1/../../../../x86_64-asusb450eg-linux-gnu/bin/ld: pcm_dmix.c:(.text+0x1d00): undefined reference to `pcm_frames_diff'
/home/asavah/kross/host/asusb450eg/lib/gcc/x86_64-asusb450eg-linux-gnu/10.2.1/../../../../x86_64-asusb450eg-linux-gnu/bin/ld: pcm/.libs/libpcm.a(pcm_dshare.o): in function `snd_pcm_dshare_sync_area':
pcm_dshare.c:(.text+0x2af): undefined reference to `pcm_frames_diff'
/home/asavah/kross/host/asusb450eg/lib/gcc/x86_64-asusb450eg-linux-gnu/10.2.1/../../../../x86_64-asusb450eg-linux-gnu/bin/ld: pcm_dshare.c:(.text+0x2e7): undefined reference to `pcm_frames_diff'
/home/asavah/kross/host/asusb450eg/lib/gcc/x86_64-asusb450eg-linux-gnu/10.2.1/../../../../x86_64-asusb450eg-linux-gnu/bin/ld: pcm/.libs/libpcm.a(pcm_dshare.o):pcm_dshare.c:(.text+0x9f2): more undefined references to `pcm_frames_diff' follow
collect2: error: ld returned 1 exit status

Note the difference between pcm_frames_diff (typo?) and pcm_frame_diff (as defined in the header)

Ping @perexg

perexg added a commit that referenced this issue Oct 14, 2020
BugLink: #85
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
@perexg
Copy link
Member

perexg commented Oct 14, 2020

Yep, typo. Fixed in 0128af6 . Thanks for the report.

@perexg perexg closed this as completed Oct 14, 2020
lgirdwood pushed a commit to thesofproject/alsa-lib that referenced this issue Dec 3, 2020
BugLink: alsa-project#85
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants