hw: add "min_rate" and "max_rate" as alternatives to single "rate" parameter #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameter Signed-off-by: Benedek Kupper <benedek.kupper@streamunlimited.com>
perexg
requested changes
Nov 16, 2021
| err = _snd_pcm_hw_param_set_minmax(params, SND_PCM_HW_PARAM_RATE, | ||
| hw->rate, 0, hw->rate + 1, -1); | ||
| #if 1 // TODO: find out which arguments are correct | ||
| hw->rates.min, 0, hw->rates.max + 1, -1); |
| @@ -1863,6 +1870,26 @@ int _snd_pcm_hw_open(snd_pcm_t **pcmp, const char *name, | |||
| rate = val; | |||
| continue; | |||
| } | |||
| if (strcmp(id, "min_rate") == 0) { | |||
There was a problem hiding this comment.
I would add extension to the rate field like:
rate [ 44100 48000 ]
The parser stores this as compound internally:
rate.0 44100
rate.1 48000
You may use a loop to parse this or snd_config_search() fcn (and look for '0' and '1' keys). There is snd_config_is_array() to check, if the compound is array.
perexg
added a commit
that referenced
this pull request
May 20, 2022
Allow three configuration types: rate 48000 # single rate rate [ 48000 ] # single rate (2nd) rate [ 44100 48000 ] # range Fixes: #191 Fixes: ac04cb63 ("hw: add "min_rate" and "max_rate" as alternatives to single "rate" parameter") Signed-off-by: Jaroslav Kysela <perex@perex.cz>
|
I implemented my suggestion in 7f2d6c3 and applied your change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our typical use case is to limit the rate to between 44100 and 48000, as with these boundaries the resampling becomes easier, than if only allowing 48000.