pcm: Add MSBITS subformat options #342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow userspace applications to select subformats easily just like in snd_pcm_format_t case - by string conversion. Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
|
Related alsa-utils PR: aplay: Add option for specifying subformat. |
|
This will be paired with relevant kernel updates, posting as RFC for now. Will link the alsa-devel thread once the patchset is there. The patchset ALSA/ASoC: hda: Address format selection limitations and ambiguity has been posted on alsa-devel. |
crojewsk-intel
force-pushed
the
crojewsk/subfmt_msbits
branch
from
628ad04
to
bb90b8c
Compare
crojewsk-intel
changed the title
|
Changes in v2:
|
Improve granularity of format selection for S32/U32 formats by adding masks representing 20, 24 and 32 most significant bits. Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Update snd_pcm_subformat_t getters and setters so they no longer throw warnings when building. Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
crojewsk-intel
force-pushed
the
crojewsk/subfmt_msbits
branch
from
bb90b8c
to
1de598f
Compare
|
Bumping the subject. Dropping [RFC] as the kernel series [PATCH v5 00/16] ALSA/ASoC: hda: Address format selection limitations and ambiguity has been merged into Takashi's for-next. |
crojewsk-intel
changed the title
perexg
pushed a commit
that referenced
this pull request
Dec 8, 2023
Improve granularity of format selection for S32/U32 formats by adding masks representing 20, 24 and 32 most significant bits. Closes: #342 Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
perexg
pushed a commit
that referenced
this pull request
Dec 8, 2023
Update snd_pcm_subformat_t getters and setters so they no longer throw warnings when building. Closes: #342 Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve granularity of format selection for S32/U32 formats by adding masks representing 20, 24 and 32 most significant bits. As a preparation step introduce
snd_pcm_subformat_value()for easy name-to-subformat conversions.While at it, fix few warnings that pop up in subformat-related code during compilation.