Clang: fix versioned symbol build errors #376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modern autoconf practice says AC_OUTPUT() should be called with no arguments and generated configuration files should be specified by calling AC_CONFIG_FILES() before AC_OUTPUT(). Update configure.ac to follow this practice.
Add guards for optional alisp symbols. This ensures that the Versions file does not contain undefined symbols when building alisp support is disabled. Fixes Gentoo bugs 914511 (https://bugs.gentoo.org/914511), 914643 (https://bugs.gentoo.org/914643), and 919417 (https://bugs.gentoo.org/919417). Fixes bug alsa-project#305 Fixes alsa_lisp symbol error reported in bug alsa-project#356 Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
Configure script allows for the disabling of the pcm module. When disabled, the pcm symbols will not be available. Add guards to remove symbols from version map when not present.
Review of Versions.in does not list any symbols defined in the libatopology library. Naming undefined symbols in a version script causes build failures with ld.lld when using default flags.
perexg
added a commit
that referenced
this pull request
Jan 23, 2024
A slightly different solution is preferred than PR recommends (bellow). Only symbols with snd_ prefix should be public. Create a minimal Versions file for libatopology. Link: #376 Signed-off-by: Jaroslav Kysela <perex@perex.cz>
perexg
pushed a commit
that referenced
this pull request
Jan 24, 2024
file does not contain undefined symbols when building alisp support is disabled. Fixes Gentoo bugs 914511 (https://bugs.gentoo.org/914511), 914643 (https://bugs.gentoo.org/914643), and 919417 (https://bugs.gentoo.org/919417). Fixes bug #305 Fixes alsa_lisp symbol error reported in bug #356 Closes: #376 Fixes: #305 Link: #356 Signed-off-by: Nicholas Vinson <nvinson234@gmail.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
perexg
pushed a commit
that referenced
this pull request
Jan 24, 2024
disabled, the pcm symbols will not be available. Add guards to remove symbols from version map when not present. Closes: #376 Signed-off-by: Nicholas Vinson <nvinson234@gmail.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
perexg
pushed a commit
that referenced
this pull request
Jan 24, 2024
Modern autoconf practice says AC_OUTPUT() should be called with no arguments and generated configuration files should be specified by calling AC_CONFIG_FILES() before AC_OUTPUT(). Update configure.ac to follow this practice. Closes: #376 Signed-off-by: Nicholas Vinson <nvinson234@gmail.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
perexg
pushed a commit
that referenced
this pull request
Jan 24, 2024
Add guards for optional alisp symbols. This ensures that the Versions file does not contain undefined symbols when building alisp support is disabled. Fixes Gentoo bugs 914511 (https://bugs.gentoo.org/914511), 914643 (https://bugs.gentoo.org/914643), and 919417 (https://bugs.gentoo.org/919417). Fixes bug #305 Fixes alsa_lisp symbol error reported in bug #356 Closes: #376 Fixes: #305 Link: #356 Signed-off-by: Nicholas Vinson <nvinson234@gmail.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
perexg
pushed a commit
that referenced
this pull request
Jan 24, 2024
Configure script allows for the disabling of the pcm module. When disabled, the pcm symbols will not be available. Add guards to remove symbols from version map when not present. Closes: #376 Signed-off-by: Nicholas Vinson <nvinson234@gmail.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building alsa-lib with the following settings
the build fails with errors similar to
This PR corrects that issue and additional issues found while making corrections so alsa-lib will successfully build using clang and ld.lld.