Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jack: add option to allow non-jack-aligned period size #14

Closed
wants to merge 1 commit into from

Conversation

aditpape
Copy link
Contributor

Commit 72337f1 forces ALSA period size
to be exact multiple of the JACK daemon period size.
There are good reasons to align the period size, but completely disallowing non aligned periods is too restrictive.
This patch adds an option "align_psize" which allows to optionally revert to original behavior.

Signed-off-by: Andreas Pape apape@de.adit-jv.com

Commit 72337f1 forces ALSA period size
to be exact multiple of the JACK daemon period size.
There are good reasons to align the period size, but completely disallowing non aligned periods is too restrictive.
This patch adds an option "align_psize" which allows to optionally revert to original behavior.

Signed-off-by: Andreas Pape <apape@de.adit-jv.com>
@aditpape
Copy link
Contributor Author

@perexg, @tiwai : any objections or doubts on this PR?

@aditpape
Copy link
Contributor Author

This PR is also an alternate solution for issue #12 .
(The proposed solution for issue #12 itself does not conflict with this PR and could still be considered in addition..)

@aditpape
Copy link
Contributor Author

@perexg : sorry to ping again...
Is there a chance to get it in, now that we even have a linked issue report?
THX,
Andreas

@perexg
Copy link
Member

perexg commented May 25, 2021

Merged in 3b6d4fa . Thank you.

@perexg perexg closed this May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants