Fix a52 for the recent avcodec #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: 72b1bd9 ("jack: Make the running state tracing code more robust to multi-thread access.") Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Since it's used as AVPacket payload, the API requires it to be padded. BugLink: alsa-project#23 Signed-off-by: James Almer <jamrial@gmail.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
BugLink: alsa-project#23 Signed-off-by: James Almer <jamrial@gmail.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
ffmpeg 4.4 is the last version with avcodec_encode_audio2(). Starting from the next release the new decoupled input-output API will be the only one available. BugLink: alsa-project#23 Signed-off-by: James Almer <jamrial@gmail.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
It's no longer available starting with LIBAVCODEC_VERSION_MAJOR == 59. BugLink: alsa-project#23 Signed-off-by: James Almer <jamrial@gmail.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Intel HDMI: PERIOD_SIZE: [32 4272000] PERIOD_BYTES: [128 17088000] PERIODS: [2 32] BUFFER_SIZE: [64 8544000] BUFFER_BYTES: [256 34176000] Selected: PERIOD_SIZE: 768 PERIOD_BYTES: 3072 PERIODS: 32 BUFFER_SIZE: 24576 BUFFER_BYTES: 98304 The a52_hw_params() tries to set the big 4271616 buffer size (frames) for speaker-test which is beyond the maximal slave buffer. BugLink: alsa-project#23 Signed-off-by: Jaroslav Kysela <perex@perex.cz>
The recent a52 encoder in ffmpeg accepts planar S32 (fixed encoder) or planar float (normal encoder) only. Extend the routines to support all combinations of 16-bit, 32-bit and float source samples. BugLink: alsa-project#23 Signed-off-by: Jaroslav Kysela <perex@perex.cz>
The buffer offset was incorrectly calculated in samples. Signed-off-by: Takashi Iwai <tiwai@suse.de>
A more modern one for the recent API. Signed-off-by: Takashi Iwai <tiwai@suse.de>
|
I pushed all patches to the master branch (changed pcm_a52 prefix to a52 for consistency). Thank you Takashi. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.