hdspmixer: Hardware output loopback toggle buttons #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds "LPBK" buttons to the output strip channels for toggling the hardware output loopback functionality recently added for HDSP9632. The preset data is just appended to the preset file so that it can still be loaded in older versions.
This adds "LPBK" buttons to the output strip channels for toggling the hardware output loopback functionality recently added for HDSP9632. The preset data is just appended to the preset file so that it can still be loaded in older versions.
pfandl
changed the title
|
What was the reason to close this PR? I see you sent the patch to ML, but we can merge the patches from github, too. |
|
Hi, I was asked to send it to ML and since this is a little different than the ones I sent on the ML i closed this. |
|
I don't see the ML request in your conversation with @tiwai . Link: https://lore.kernel.org/alsa-devel/2e9bb0b8-ee14-9dc9-1bd8-ecffca3982ac@gmail.com/ I'll close this when merged. |
|
I asked him directly via email since I wasn't sure if this PR got noticed because the reaction time on the ML was so fast. |
|
Hi @perexg the patch was merged, I'll close this if I may. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, as promised in the sound/pci/rme9652 patch here are the user land changes which provide the user the ability to toggle the hardware output loopback functionality per output channel. I tried to hide the buttons for devices which do not expose the snd controls yet, but due to probably unnecessary struggle i cancelled that. Please let me know though should you want them removed for not yet enabled devices.