Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AMD ACP Microphone devices for Yellow Carp platform #136

Closed
vijendarmukunda opened this issue Jan 27, 2022 · 8 comments
Closed

Comments

@vijendarmukunda
Copy link

We have tried to add similar changes which were applied for Renoir platform for YC platform by following below link.
#54

But we are unable to create links.

Without ALSA UCM changes, we are able to observe similar issues earlier reported on Renoir platform as mentioned below.

  1. Fallback profile is getting loaded and capture endpoint name is not listed as "Digital Microphone"
  2. Mic Mute Led button is not reflected with Mute status.

Attached pa-info and alsa info output.
painfo.txt
alsa-info.txt
a

perexg added a commit to perexg/alsa-ucm-conf that referenced this issue Jan 27, 2022
Link: alsa-project#136
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
@perexg
Copy link
Member

perexg commented Jan 27, 2022

Could you test changes in the above PR #138?

@vijendarmukunda
Copy link
Author

will verify the changes and let you know the result

@superm1
Copy link

superm1 commented Jan 31, 2022

I had some test on an upcoming platform that uses this, and I can confirm that this is fixed:

Fallback profile is getting loaded and capture endpoint name is not listed as "Digital Microphone"

However the mic mute LED doesn't work by default. So I ran alsactl clean and rebooted the machine.
Here is the logs from muting or not muting in the GUI:
painfo_not_muted_logs.txt
pactl_list_sources_muted.txt
pactl_list_sources_not_muted.txt
painfo_muted_logs.txt

Another interesting thing I found by default in the mixers that there is a "Capture" source that is enabled.
image
If I disable that source like this:
image

Then the GUI starts working for controlling mic mute LED.

@perexg
Copy link
Member

perexg commented Jan 31, 2022

It's correct behavior. Mic mute LED is connected to two paths - the software defined Mic LED mixer control and HDA capture control by default. Both must be off to turn on the mic mute LED.

The mixer paths may be controlled using pavucontrol or any other tool for the pulseaudio/pipewire configuration (select the input path + mute sound button).

perexg added a commit that referenced this issue Jan 31, 2022
Link: #136
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
@superm1
Copy link

superm1 commented Jan 31, 2022

Yeah, from pavucontrol if I go and mute both the "Family 17h (Models 10h-1fh) HD Audio Controller Headphones Stereo Microphone" and the "Family 17h (Models 10h-1fh) HD Audio Controller Digital Microphone" from pavucontrol then I can observe the LED does turn on. I guess we can close this then.

@superm1
Copy link

superm1 commented Jan 31, 2022

BTW - that Family ### (Models ###) business is completely wrong - this is a family 19h model 44h. Where does it populate that from?

@perexg
Copy link
Member

perexg commented Jan 31, 2022

I think that those strings are from udev - udevadm info /sys/class/sound/card0 (maybe another card).

@superm1
Copy link

superm1 commented Jan 31, 2022

Ah thanks, it looks like they pull from the PCI database.

E: ID_MODEL_FROM_DATABASE=Family 17h (Models 10h-1fh) HD Audio Controller

I'll submit a request there to make them more generic.

@vijendarmukunda please close this issue as Jaraslov committed the fix above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants