Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sof-hda-dsp: Support systems without integrated graphics audio #15

Closed
wants to merge 1 commit into from

Conversation

kv2019i
Copy link
Contributor

@kv2019i kv2019i commented Mar 5, 2020

On systems where integrated graphics audio is not present
or is disabled, the HDMI PCM nodes are disabled. Add rules to
detect these systems by checking presence of HDMI jack controls
with UCM2 rules.

Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com

@kv2019i
Copy link
Contributor Author

kv2019i commented Mar 5, 2020

@juimonen and @perexg please review.

You can test this on any system that supports SOF (and recent kernel) with following kernel option:

options snd_sof_intel_hda_common codec_mask=0x1

... this will disable HDMI HDA codec. On older kernel SOF probe still fails, but this is fixed in recent kernel.

Or alternative a system like HP Omen17 that has no integrated graphics.

Copy link
Contributor

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart oops, fixed

On systems where integrated graphics audio is not present
or is disabled, the HDMI PCM nodes are disabled. Add rules to
detect these systems by checking presence of HDMI jack controls
with UCM2 rules.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@perexg
Copy link
Member

perexg commented Mar 5, 2020

And the support for the fourth HDMI output? I think that it was added to the driver, wasn't?

@kv2019i
Copy link
Contributor Author

kv2019i commented Mar 5, 2020

@perexg wrote:

And the support for the fourth HDMI output? I think that it was added to the driver, wasn't?

Yes, that needs to be added in a separate patch.

@perexg
Copy link
Member

perexg commented Mar 5, 2020

Merged via 4722f5b .

@perexg perexg closed this Mar 5, 2020
@kv2019i
Copy link
Contributor Author

kv2019i commented Apr 21, 2020

@perexg Btw, any plan for a new alsa-ucm release? It seems quite a few people are hitting issues without this patch in alsa-ucm (e.g. thesofproject/linux#1985 and thesofproject/linux#1917 at least, but in general any laptop with NVidia GPU). Without this, Pulseaudio keeps trying to open the non-existing i915 HDMI PCM devices.

@plbossart
Copy link
Contributor

@kv2019i alsa-ucm-conf or alsa-lib?

@kv2019i
Copy link
Contributor Author

kv2019i commented Apr 21, 2020

@plbossart wrote:

@kv2019i alsa-ucm-conf or alsa-lib?

alsa-ucm-conf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants