ucm2: add profile for the Librem 5 #181
Conversation
|
@craftyguy thanks for taking a look at this! Would be great to have it upstream. There's rework pending here https://source.puri.sm/Librem5/librem5-base/-/merge_requests/311 which might make sense to have upstream right away. What do you think? |
@agx I saw that, and based on the comments it still seemed WIP with the last update a couple of months ago... So I thought it would be better to upstream a known working config, then it could be tweaked later to perfection. But obviously if it's in much better shape than what I think from reading the discussion, I'd have no problem updating this patch. My main motivation is to just get something upstream to hopefully help with audio on this platform breaking every time alsa is updated. |
|
@craftyguy yeah I understand that, it's a drag with that being only downstream. That said I'd go for the reworked one as otherwise we might hit odd mixer settings when switching to the newer version. |
|
Given that reworking the profile seems to have stalled I think this would be good to have as a starting point! (Tested on my Librem 5) |
|
and just in case: |
|
@perexg thank you for the detailed feedback, I appreciate it! I tried to implement the changes you called for, by looking at other conf for examples, but I'm really not a ucm expert so please let me know if I misinterpreted something you said / more changes are needed for this to be acceptable 😄 |
There was a problem hiding this comment.
The verb should also call DisableSequence for all devices when enabled like:
https://github.com/alsa-project/alsa-ucm-conf/blob/master/ucm2/HDA/HiFi.conf#L3-L9
Tested-by: Guido Günther <agx@sigxcpu.org>
cc @agx