Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UCM files for avs driver #418

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

amadeuszslawinski-intel

Present in this pull request are UCM files for some of the devices available on market that we were able to test.
They are meant to be used with avs driver and relevant topology files.

@perexg
Copy link
Member

perexg commented May 26, 2024

Move the configurations to ucm2/Intel/avs subtree, please. Also, try to merge the identical device configurations to simplify the configuration maintenance.

@amadeuszslawinski-intel
Copy link
Author

I don't mind moving them, but on systems I've tested pulseaudio looked into /usr/share/alsa/ucm2/conf.d, not /usr/share/alsa/ucm2/Intel/avs. Am I missing something, either on driver or ucm side?

@perexg
Copy link
Member

perexg commented May 28, 2024

The conf.d is just for symlinks for the toplevel config file to keep configurations organized more logically. I would suggest to follow other configs. Also, the ucm2/Intel/ subtree may be restructured more logically (I mean grouping older SST and new AVS configs to separate subdirs).

Amadeusz Sławiński added 9 commits May 28, 2024 15:24
Add 2 channels and 4 channels DMIC configurations.

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Add HDMI configurations with 3 playbacks.

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Google Eve uses:
MAX98927 codec for Speakers
RT5663 codec for Headphones/Headset
RT5514 codec for Digital Microphone
hdaudioB0D2 codec for HDMI

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
HP Soraka uses:
MAX98927 codec for Speakers
RT5663 codec for Headphones/Headset
DMIC codec for Digital Microphone
hdaudioB0D2 codec for HDMI

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Google Atlas uses:
MAX98373 codec for Speakers
DA7219 codec for Headphones/Headset
DMIC codec for Digital Microphone
hdaudioB0D2 codec for HDMI

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Google Cave uses:
MAX98357A codec for Speakers
NAU8825 codec for Headphones/Headset
DMIC codec for Digital Microphone
hdaudioB0D2 codec for HDMI

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Google Coral uses:
MAX98357A codec for Speakers
DA7219 codec for Headphones/Headset
DMIC codec for Digital Microphone
hdaudioB0D2 codec for HDMI

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Acer Lars uses:
MAX98357A codec for Speakers
NAU8825 codec for Headphones/Headset
DMIC codec for Digital Microphone
hdaudioB0D2 codec for HDMI

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
HP Chell uses:
SSM4567 codec for Speakers
NAU8825 codec for Headphones/Headset
DMIC codec for Digital Microphone
hdaudioB0D2 codec for HDMI

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
@amadeuszslawinski-intel
Copy link
Author

Ah, I've missed that, I've moved the files. I also updated topologies to reuse DMIC and HDMI configuration where possible, as those are fairly generic. I've left codec ones separated, as even though there is some reuse possible between models, there also seem to be different expectations between some of them.

Copy link
Member

@perexg perexg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to merge or symlink the similar files. Like:

$ diff -u Google-Atlas-1.0-HiFi.conf Google-Coral-rev2-HiFi.conf
$ echo $?
0

For this given example, you can just create one file for all avs_da7219 devices avs_da7219.conf and avs_da7219-HiFi.conf. If new devices will differ a bit, we can use condition configuration blocks to handle them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants