-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UCM files for avs driver #418
base: master
Are you sure you want to change the base?
Add UCM files for avs driver #418
Conversation
82c1504
to
669ce04
Compare
Move the configurations to |
I don't mind moving them, but on systems I've tested pulseaudio looked into /usr/share/alsa/ucm2/conf.d, not /usr/share/alsa/ucm2/Intel/avs. Am I missing something, either on driver or ucm side? |
The conf.d is just for symlinks for the toplevel config file to keep configurations organized more logically. I would suggest to follow other configs. Also, the ucm2/Intel/ subtree may be restructured more logically (I mean grouping older SST and new AVS configs to separate subdirs). |
Add 2 channels and 4 channels DMIC configurations. Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Add HDMI configurations with 3 playbacks. Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Google Eve uses: MAX98927 codec for Speakers RT5663 codec for Headphones/Headset RT5514 codec for Digital Microphone hdaudioB0D2 codec for HDMI Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
HP Soraka uses: MAX98927 codec for Speakers RT5663 codec for Headphones/Headset DMIC codec for Digital Microphone hdaudioB0D2 codec for HDMI Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Google Atlas uses: MAX98373 codec for Speakers DA7219 codec for Headphones/Headset DMIC codec for Digital Microphone hdaudioB0D2 codec for HDMI Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Google Cave uses: MAX98357A codec for Speakers NAU8825 codec for Headphones/Headset DMIC codec for Digital Microphone hdaudioB0D2 codec for HDMI Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Google Coral uses: MAX98357A codec for Speakers DA7219 codec for Headphones/Headset DMIC codec for Digital Microphone hdaudioB0D2 codec for HDMI Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Acer Lars uses: MAX98357A codec for Speakers NAU8825 codec for Headphones/Headset DMIC codec for Digital Microphone hdaudioB0D2 codec for HDMI Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
HP Chell uses: SSM4567 codec for Speakers NAU8825 codec for Headphones/Headset DMIC codec for Digital Microphone hdaudioB0D2 codec for HDMI Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
669ce04
to
865047c
Compare
Ah, I've missed that, I've moved the files. I also updated topologies to reuse DMIC and HDMI configuration where possible, as those are fairly generic. I've left codec ones separated, as even though there is some reuse possible between models, there also seem to be different expectations between some of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to merge or symlink the similar files. Like:
$ diff -u Google-Atlas-1.0-HiFi.conf Google-Coral-rev2-HiFi.conf
$ echo $?
0
For this given example, you can just create one file for all avs_da7219
devices avs_da7219.conf
and avs_da7219-HiFi.conf
. If new devices will differ a bit, we can use condition configuration blocks to handle them.
Present in this pull request are UCM files for some of the devices available on market that we were able to test.
They are meant to be used with avs driver and relevant topology files.